-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/9.0] Add .slnx fallback for TestHost content root discovery #64953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/9.0
Are you sure you want to change the base?
[release/9.0] Add .slnx fallback for TestHost content root discovery #64953
Conversation
|
Hi @@copilot. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Co-authored-by: halter73 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds non-breaking .slnx fallback support to the UseSolutionRelativeContentRoot method in TestHost. When searching for solution files with the "*.sln" pattern, the method now falls back to searching for .slnx files if no .sln file is found, preventing the InvalidOperationException that would previously occur.
Key changes:
- Added .slnx fallback logic that only activates when no .sln file is found and the search pattern is "*.sln"
- Maintained .sln precedence to avoid breaking changes where .slnx files could shadow .sln files in parent directories
- Added comprehensive tests validating both the fallback behavior and .sln precedence
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Hosting/TestHost/src/WebHostBuilderExtensions.cs | Added conditional .slnx fallback logic after .sln search fails, maintaining backward compatibility |
| src/Hosting/TestHost/test/WebHostBuilderExtensionsTests.cs | New test file with two tests: one verifying .slnx fallback and one verifying .sln takes precedence over .slnx |
|
/backport to release/8.0 |
|
Started backporting to |
Add .slnx fallback for TestHost content root discovery
Description
This pull request adds
.slnxfallback support to the test-onlyUseSolutionRelativeContentRootmethod in theMicrosoft.AspNetCore.TestHost. When searching for solution files with the*.slnpattern, the method now falls back to searching for.slnxfiles if no.slnfile is found, preventing theInvalidOperationExceptionthat would previously occur before test developers can easily callUseSolutionRelativeContentRootthemselves.This has already been fixed in .NET 10 by #61305, but that included public API changes, so this is not a direct backport. Unlike, the .NET 10 change that treats
.slnxand.slnequivalently by default, this change will only fall back to looking for an*.slnxfile if the test server would otherwise throw anInvalidOperationExceptiondue to not being able to find an ".sln" file.Fixes #61304 in .NET 9.
Customer Impact
#61304 has gotten a lot of attention, because it is a pain point for migrating solution from
.slnto.slnx.Test projects that worked fine with an
.sln-based solution throw after migrating to*.slnxbefore developers even get access to theIWebHostBuilder, so they don't get the opportunity to easily manually reconfigure the content root by callingUseSolutionRelativeContentRootwith "*.slnx". Instead, the current general workaround is fragile and unintuitive:#61304 (comment)
Regression?
Not technically, but you could consider it a regression in behavior when migrating from
.slnto.slnxsolutions.Risk
This change only has an impact if starting the test server would otherwise throw an
InvalidOperationExceptionearly during initialization due to not being able to find an ".sln" file.Verification
Packaging changes reviewed?
.slnxfallback for content root lookup.Description
Problem:
UseSolutionRelativeContentRootthrew when only a.slnxexisted, and.slnxcould shadow.slnin parents.Changes:
.slnprecedence; if none found, retry search for.slnxwithout changing API..slnpreference and.slnxfallback discovery.Example:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.